Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AAD certificate thumbrpint to constants #1608

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Add AAD certificate thumbrpint to constants #1608

merged 1 commit into from
Nov 15, 2022

Conversation

oldalton
Copy link
Member

Proposed changes

Add AAD certificate thumbprint to returned deviceInfo.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@oldalton oldalton requested a review from a team as a code owner November 15, 2022 17:00
azure-pipelines[bot]
azure-pipelines bot reviewed Nov 15, 2022
View reviewed changes
MSAL/IdentityCore
@@ -1 +1 @@
Subproject commit 3b487e715a35d641150221bc3addc6eeeff82058
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@oldalton oldalton merged commit 0fc70d8 into dev Nov 15, 2022
@oldalton oldalton deleted the oldalton/aad_cert_tprint branch November 15, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azure-pipelines azure-pipelines[bot] azure-pipelines left review comments

@Veena11 Veena11 Veena11 approved these changes

@antonioalwan antonioalwan Awaiting requested review from antonioalwan antonioalwan is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oldalton @Veena11