Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make private method to calculate OS version protected #1660

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Make private method to calculate OS version protected #1660

merged 2 commits into from
Mar 1, 2023

Conversation

oldalton
Copy link
Member

Proposed changes

Make private method to calculate OS version protected

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@oldalton oldalton requested a review from a team as a code owner February 25, 2023 19:55
azure-pipelines[bot]
azure-pipelines bot reviewed Mar 1, 2023
View reviewed changes
MSAL/IdentityCore
@@ -1 +1 @@
Subproject commit c973569c1b8f218a6b5657db644be9759abba8c8
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

@oldalton oldalton merged commit 49c986b into dev Mar 1, 2023
@oldalton oldalton deleted the oldalton/platform_sso_config branch March 1, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azure-pipelines azure-pipelines[bot] azure-pipelines left review comments

@fidelianawar fidelianawar fidelianawar approved these changes

@kaisong1990 kaisong1990 Awaiting requested review from kaisong1990 kaisong1990 is a code owner automatically assigned from AzureAD/appleidentityteam

@hieunguyenmsft hieunguyenmsft Awaiting requested review from hieunguyenmsft hieunguyenmsft is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oldalton @fidelianawar