Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support external SSO keys in PkeyAuth handling #1662

Merged
merged 10 commits into from
Mar 11, 2023
Merged

Support external SSO keys in PkeyAuth handling #1662

merged 10 commits into from
Mar 11, 2023

Conversation

oldalton
Copy link
Member

Proposed changes

Support external SSO extension context in PkeyAuth calls. This is needed if device keys are supplied externally by the SSO extension.
There're a lot of changes here, but majority of them are simply passing the ssoContext between all layers.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@oldalton oldalton requested a review from a team as a code owner February 28, 2023 05:31
@oldalton oldalton requested review from hieunguyenmsft and fidelianawar and removed request for a team February 28, 2023 05:31
azure-pipelines[bot]
azure-pipelines bot reviewed Feb 28, 2023
View reviewed changes
MSAL/IdentityCore Outdated
@@ -1 +1 @@
Subproject commit d385d4d01ca8ac3913db308a5acc284b1cced590
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not update CHANGELOG.md.

Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.

Base automatically changed from oldalton/platform_sso_config to dev March 1, 2023 01:17
@oldalton oldalton merged commit 281cb1d into dev Mar 11, 2023
@oldalton oldalton deleted the oldalton/external_sso_context_pkeyauth branch March 11, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azure-pipelines azure-pipelines[bot] azure-pipelines left review comments

@Veena11 Veena11 Veena11 approved these changes

@fidelianawar fidelianawar fidelianawar approved these changes

@hieunguyenmsft hieunguyenmsft Awaiting requested review from hieunguyenmsft hieunguyenmsft is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oldalton @Veena11 @fidelianawar