Support read device info when ecc is on. #1714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oldalton
approved these changes
May 9, 2023
antrix1989
force-pushed
the
sedemche/ecc_device_info
branch
from
5bb7c6c
to
8384a58
Compare
borgesmb
pushed a commit
that referenced
this pull request
Oct 23, 2023
* ciam-master: (139 commits) update submodules Updating MSAL framework checksum & url for 1.2.12 [skip ci] Update CommonCore to master Update CommonCore to master Update Common Core submodule after fixing conflict. Update version & submodule Update submodule trying to fix merge conflict Support read device info when ecc is on. (#1714) Add additional error code when getting token for jit troubleshooting page fails. Update common core Update submodule updating MSAL PR to point to common core dev Add new error codes from CommonCore fixing code syntax adding test CIAM authorities to MSAL test app adding ciam authority tests Fix error 'A function declaration without a prototype is deprecated in all versions of C' adding automation tests to ciam authority Updating MSAL framework checksum & url for 1.2.11 [skip ci] ... # Conflicts: # MSAL/IdentityCore
borgesmb
pushed a commit
that referenced
this pull request
Oct 23, 2023
* ciam-master: (147 commits) check telemetry event for all the signIn controller tests remove word save from log add more appropriate log for signInController flow check that resendCodeError is not nil rename generic and internal error classes, created a new ResendCodeError class rename addNcaFlag to addNCAFlag use compactMap instead of array attribute use username instead of email, do not call stop telemetry on main queue update submodules Updating MSAL framework checksum & url for 1.2.12 [skip ci] Update CommonCore to master Update CommonCore to master Update Common Core submodule after fixing conflict. Update version & submodule Update submodule trying to fix merge conflict Support read device info when ecc is on. (#1714) Add additional error code when getting token for jit troubleshooting page fails. Update common core Update submodule ... # Conflicts: # MSAL/MSAL.xcodeproj/project.pbxproj # MSAL/src/native_auth/controllers/sign_in/MSALNativeAuthSignInController.swift # MSAL/src/native_auth/public/state_machine/error/SignInStartError.swift # MSAL/src/native_auth/public/state_machine/error/SignUpStartError.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Support read device info when ecc is on.
Unify the api (return same response as SSO ext returns for primary registration call)
Core PR: AzureAD/microsoft-authentication-library-common-for-objc#1240
Type of change
Risk
Additional information