Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme with native auth content #2080

Merged
merged 12 commits into from Mar 26, 2024

Conversation

Dickson-Mwendia
Copy link
Contributor

@Dickson-Mwendia Dickson-Mwendia commented Mar 4, 2024

Proposed changes

Describe what this PR is trying to do.

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@Dickson-Mwendia Dickson-Mwendia requested a review from a team as a code owner March 4, 2024 08:53
@Dickson-Mwendia Dickson-Mwendia marked this pull request as draft March 4, 2024 08:54
README.md Outdated
The MSAL library for iOS and macOS gives your app the ability to begin using the [Microsoft Identity platform](https://aka.ms/aaddev) by supporting [Azure Active Directory](https://azure.microsoft.com/en-us/services/active-directory/) and [Microsoft Accounts](https://account.microsoft.com) in a converged experience using industry standard OAuth2 and OpenID Connect. The library also supports [Azure AD B2C](https://azure.microsoft.com/services/active-directory-b2c/) for those using our hosted identity management service.
| Documentation | Sample Code | Library Reference | Support | Feedback|
|-------------------------------|---------------------------|-------------------|---------|----------|
| [MSAL iOS and macOS documentation](https://learn.microsoft.com/en-us/entra/msal/objc/) <br/> [Workforce apps tutorials](https://learn.microsoft.com/en-us/entra/identity-platform/tutorial-v2-ios)<br/> Customer apps tutorials <br/> • Browser-delegated <br/>• Native Authentication | [Workforce samples](https://learn.microsoft.com/en-us/entra/identity-platform/sample-v2-code?tabs=framework#ios) <br/> [Customer samples](https://learn.microsoft.com/en-us/entra/identity-platform/sample-v2-code?tabs=apptype#mobile) | [ MSAL iOS and macOS reference](https://azuread.github.io/microsoft-authentication-library-for-objc/) | [Support](https://github.com/AzureAD/microsoft-authentication-library-for-objc/blob/dev/README.md#community-help-and-support) | [Feedback](https://forms.office.com/r/xuBV0CzEih) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Ignore for now, just saw it's in Draft
Because the links are one under the other they aren't clear that they 2 different links.
There should be a way to differentiate them
Screenshot 2024-03-04 at 13 15 05
Not sure how the name on Github "Workforce apps tutorials" connects to the name in the link "Tutorial: Sign in users and call Microsoft Graph from an iOS or macOS app" - https://learn.microsoft.com/en-us/entra/identity-platform/tutorial-v2-ios
Same for the links under "Workforce samples" which leads to https://learn.microsoft.com/en-us/entra/identity-platform/sample-v2-code?tabs=framework#ios and the MSAL iOS and macOS reference which leads to the Mobile - https://learn.microsoft.com/en-us/entra/identity-platform/sample-v2-code?tabs=apptype#mobile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spetrescu84 for an early review here.

For the documentation updates and links:

As for the code samples, we also need to differentiate the between workforce and customer sample apps, that's why we have two links. Eventually, the links will point to the code samples browser, such as (https://learn.microsoft.com/en-us/samples/browse/?products=microsoft-authentication-library) I'm working to get all code samples for iOS and macOS onboarded there.

@nilo-ms nilo-ms added the native-auth Code related to native authentication label Mar 4, 2024
@Dickson-Mwendia Dickson-Mwendia marked this pull request as ready for review March 6, 2024 14:10
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@iambmelt iambmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline - thanks!

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com>
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Dickson-Mwendia and others added 3 commits March 8, 2024 14:16
Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com>
README.md Show resolved Hide resolved
@Dickson-Mwendia
Copy link
Contributor Author

@iambmelt could you please merge this. Looks like I don't have the permissions .

@iambmelt
Copy link
Member

@iambmelt could you please merge this. Looks like I don't have the permissions .

@Dickson-Mwendia I've requested another member of our team sign-off before I do /cc @fidelianawar @Veena11

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Dickson-Mwendia and others added 2 commits March 18, 2024 15:09
Co-authored-by: Brian Melton-Grace <iambmelton@gmail.com>
Co-authored-by: Danilo Raspa <105228698+nilo-ms@users.noreply.github.com>
@antrix1989 antrix1989 merged commit e70e47d into AzureAD:dev Mar 26, 2024
1 check passed
iambmelt added a commit that referenced this pull request Apr 15, 2024
Reintroducing minimum version indicators that were [mistakenly?] removed in #2080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
native-auth Code related to native authentication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants