Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore broker cache #2113

Merged
merged 6 commits into from Apr 4, 2024
Merged

Ignore broker cache #2113

merged 6 commits into from Apr 4, 2024

Conversation

hieunguyenmsft
Copy link
Contributor

Proposed changes

Ignore broker cache in silent request
common core PR:
AzureAD/microsoft-authentication-library-common-for-objc#1355

Type of change

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

@hieunguyenmsft hieunguyenmsft requested a review from a team as a code owner April 3, 2024 17:36
@hieunguyenmsft hieunguyenmsft changed the title gnore broker cache Ignore broker cache Apr 3, 2024
kaisong1990
kaisong1990 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@kaisong1990 kaisong1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor question

MSAL/src/public/MSALPublicClientApplication.h Show resolved Hide resolved
@hieunguyenmsft hieunguyenmsft merged commit a65956c into dev Apr 4, 2024
6 checks passed
@hieunguyenmsft hieunguyenmsft deleted the hieund/ignore_broker_cache branch April 4, 2024 03:44
@azure-pipelines azure-pipelines bot mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azure-pipelines azure-pipelines[bot] azure-pipelines left review comments

@kaisong1990 kaisong1990 kaisong1990 approved these changes

@ameyapat ameyapat Awaiting requested review from ameyapat ameyapat is a code owner automatically assigned from AzureAD/appleidentityteam

@Veena11 Veena11 Awaiting requested review from Veena11 Veena11 is a code owner automatically assigned from AzureAD/appleidentityteam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hieunguyenmsft @kaisong1990