Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support PFX certificate authentication #684

Closed
jiasli opened this issue Apr 8, 2024 · 2 comments · Fixed by #699
Closed

[Feature Request] Support PFX certificate authentication #684

jiasli opened this issue Apr 8, 2024 · 2 comments · Fixed by #699

Comments

@jiasli
Copy link
Contributor

jiasli commented Apr 8, 2024

MSAL client type

Confidential

Problem Statement

MSAL currently requires PEM certificate for ConfidentialClientApplication:

MSAL Python requires a "private_key" in PEM format.
If your cert is in a PKCS12 (.pfx) format, you can also
`convert it to PEM and get the thumbprint <https://github.com/Azure/azure-sdk-for-python/blob/07d10639d7e47f4852eaeb74aef5d569db499d6e/sdk/identity/azure-identity/azure/identity/_credentials/certificate.py#L101-L123>`_.

The conversion logic is deferred to downstream application, such as Azure Identity library.

Proposed solution

MSAL itself can support PFX certificate authentication so that other clients such as Azure CLI can also benefit from it.

See Azure/azure-cli#28699

@rayluo
Copy link
Collaborator

rayluo commented Apr 8, 2024

See also the first comment in #685

@rayluo
Copy link
Collaborator

rayluo commented May 14, 2024

Documented in the last paragraph of this parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants