Update OwinWebApp DevApp to configure the redirect_uri parameter. #2798
Conversation
Current implementation seems to suggest that this parameter is configured in the Startup.Auth.cs file, as part of the ConfidentialClientApplicationOptions however this is not realted with the redirect_uri parameter used by the Identity Provider to redirect back to the relying party after the authentication is completed. This parameter is actually configured in OpenIdConnectAuthenticationOptions parameter.
| app.AddMicrosoftIdentityWebApp(factory); | ||
| app.AddMicrosoftIdentityWebApp(factory, updateOptions: (options) => | ||
| { | ||
| options.RedirectUri = "https://localhost:44386/"; |
There was a problem hiding this comment.
I don't think this is needed, it looked to be an app registration issue. Added https://localhost:44386/ as a redirectURI for this app in the lab. Not sure how it is even working, as this redirectURI was not registered to the app.
There was a problem hiding this comment.
I found this issue with a dSTS application, this is unrelated with the configuration of the application. This shows how to affect a specific parameter called redirect_uri.
| using Microsoft.Identity.Client; | ||
| using Microsoft.Identity.Abstractions; | ||
| using Microsoft.Identity.Web; |
There was a problem hiding this comment.
Is this needed? #Resolved
There was a problem hiding this comment.
In reading the PR description, something doesn't seem right. Will need to look from laptop later
There was a problem hiding this comment.
This is just sorting using statements alphabetically
|
The intent of this PR is to show the reader how to populate the redirect_uri parameter since we have multiple mentions of options with a similar name but none of them affect this specific parameter. This is independent of the application registration. In reply to: 2026864027 |
I understand that it's independent of the app registration, but the app didn't work with this change. The app registration also needed to be updated. The recommended way is for customers to use the configuration to set the corresponding settings, which is set up here. |
|
Agreed, that is orthogonal to this change. This change shows how to define the desired return URL for this instance. As you know the configuration on the identity provider may hold multiple return URLs for a given application. The redirect_uri parameter defines which of those should be used for the current request. The current sample makes the reader think they are able to configure this by using some of the properties called RedirectUri from our options class, but that is not true, the only way to do this is by using the object I introduced on the sample. Hence the reason for the PR> In reply to: 2083123625 |
|
Abandoning PR since sample owner doesnt see value on the change. |
Update OwinWebApp DevApp to configure the redirect_uri parameter.
Description
The redirect_uri parameter is appended to the authorize request while authenticating a user. It is used by the Identity Provider to redirect back to the relying party after the authentication is completed.
The current app implementation seems to suggest that the redirect_uri parameter is configured in the Startup.Auth.cs file already, as part of the ConfidentialClientApplicationOptions. However, this is not the case, this parameter is configured in OpenIdConnectAuthenticationOptions instead.