add LogLevel.None predicate to logging decision #2816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@westin-m can you share a screenshot of the diff now? |
|
Here is an example of seeing fewer logs from the service and client when the LogLevel for IdWeb in both is set to None. The lines highlighted in red are either omitted because the default logger is not being used, or because of the time diffs when running the app. Client: |
jmprieur
approved these changes
May 2, 2024
There was a problem hiding this comment.
LGTM
Thanks @westin-m
Please update the wiki on logging: https://github.com/AzureAD/microsoft-identity-web/wiki/Logging
src/Microsoft.Identity.Web.TokenAcquisition/MicrosoftIdentityBaseAuthenticationBuilder.cs
Outdated
Show resolved
Hide resolved
jennyf19
reviewed
May 2, 2024
src/Microsoft.Identity.Web.TokenAcquisition/MicrosoftIdentityBaseAuthenticationBuilder.cs
Show resolved
Hide resolved
jennyf19
approved these changes
May 2, 2024
@jmprieur Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Logging:LogLevel:Microsoft.Identity.Webis assigned toNonein appsettings.json, the default logger is not initialized and IdWeb does not record any logs.Before, leaving the log level at
Informationand trying to use the no-op NullIdentityModelLogger (this decision would be ignored and the default logger would be used anyway) yielded about 500 lines of logging when launching an app and making a single API call.Changing the log level to
Nonestill resulted in logs being recorded by the default logger, about 10 lines for the above scenario of a single API call.Now, choosing
Nonemeans the default logger is not instantiated and IdWeb logs nothing.