Process error AADSTS1000502 - expired certificate #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshLozensky
approved these changes
May 14, 2024
jmprieur
approved these changes
May 14, 2024
There was a problem hiding this comment.
LGTM
Thanks @westin-m
As discussed it's difficult to test end to end. But:
- we have an E2E test for the mechanism (not for that particular case)
- you've done due diligence checking with ESTS to make sure that these are all the values we need.
🚢
westin-m
added a commit
that referenced
this pull request
May 14, 2024
westin-m
added a commit
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a clause to process the error code for a certificate outside of the validity window.