[EntraWorkloadIAM] Use config protected settings #280
Conversation
AntonioND
requested review from
NarayanThiru,
bavneetsingh16,
deeksha345 and
anagg929
as code owners
|
Great PR. Thanks Antonio. Can you attach screenshot for the manual test that shows the updated command successfully deploys the Arc extension please? |
src/k8s-extension/azext_k8s_extension/partner_extensions/EntraWorkloadIAM.py
Show resolved
Hide resolved
Done! |
AntonioND
force-pushed
the
anninodi/protected
branch
3 times, most recently
from
db21ee5
to
0b1266d
Compare
AntonioND
changed the title
Instead of using regular configuration settings for the join token, use protected configuration settings.
AntonioND
force-pushed
the
anninodi/protected
branch
from
0b1266d
to
ec8db12
Compare
AntonioND
changed the title
|
Hi, @bavneetsingh16, @deeksha345, @anagg929, can we get some feedback on this PR? |
src/k8s-extension/azext_k8s_extension/partner_extensions/EntraWorkloadIAM.py
Outdated
Show resolved
Hide resolved
src/k8s-extension/azext_k8s_extension/partner_extensions/EntraWorkloadIAM.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@AntonioND , I left a couple of comments. Can you pl. review them?
Thanks! I've taken care of them now. Sorry for the delay, I was away on holiday. |
|
No worries, @AntonioND. Looks good, and I am signing off. |
|
Any news about this, @NarayanThiru? |
|
@bavneetsingh16 , can you pl. help merge this for @AntonioND ? |
Instead of using regular configuration settings for the join token, use protected configuration settings.
This is an example of the output when the extension is installed with the changes in the PR (the value of the join token isn't shown):
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)