Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a flag for AKS to AMLARC migration and set up corresponding FE… #65

Merged
merged 7 commits into from
Aug 12, 2021
Merged

Adding a flag for AKS to AMLARC migration and set up corresponding FE… #65

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9f4393c
Adding a flag for AKS to AMLARC migration and set up corresponding FE…
Jul 22, 2021
60783c7
Remove one extra line
Jul 22, 2021
c0cc8c9
Merge branch 'k8s-extension/public' into huayang/fe-migration
jonathan-innis Jul 23, 2021
8432720
Merge branch 'k8s-extension/public' into huayang/fe-migration
jonathan-innis Jul 27, 2021
438fa13
Adding Scoring FE IS_AKS_MIGRATION check logic for helm values
Aug 2, 2021
af43486
Merge branch 'k8s-extension/public' into huayang/fe-migration
jonathan-innis Aug 4, 2021
aec0ded
Merge branch 'k8s-extension/public' into huayang/fe-migration
jonathan-innis Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/k8s-extension/azext_k8s_extension/partner_extensions/AzureMLKubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,9 @@ def __init__(self):
self.privateEndpointNodeport = 'privateEndpointNodeport'
self.inferenceLoadBalancerHA = 'inferenceLoadBalancerHA'

# constants for existing AKS to AMLARC migration
self.IS_AKS_MIGRATION = 'isAKSMigration'

# reference mapping
self.reference_mapping = {
self.RELAY_SERVER_CONNECTION_STRING: [self.RELAY_CONNECTION_STRING_KEY, self.RELAY_CONNECTION_STRING_DEPRECATED_KEY],
Expand Down Expand Up @@ -211,6 +214,12 @@ def __validate_scoring_fe_settings(self, configuration_settings, configuration_p
configuration_settings['clusterPurpose'] = 'DevTest'
else:
configuration_settings['clusterPurpose'] = 'FastProd'
isAKSMigration = _get_value_from_config_protected_config(
self.IS_AKS_MIGRATION, configuration_settings, configuration_protected_settings)
isAKSMigration = str(isAKSMigration).lower() == 'true'
if isAKSMigration:
configuration_settings['scoringFe.namespace'] = "default"
configuration_settings['scoringFe.release-name'] = "scoring-fe-migration"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this work? Customer may pass any name for the extension and that is used as Helm release name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I think you are looking at an old pr version. In the latest version we skip setting up the release-name now and then in AMLARC we could use Helm Release.name instead

feSslCertFile = configuration_protected_settings.get(self.sslCertPemFile)
feSslKeyFile = configuration_protected_settings.get(self.sslKeyPemFile)
allowInsecureConnections = _get_value_from_config_protected_config(
Expand Down