Rutusamai/list build tasks for each registry #37
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import { ResourceManagementClient, SubscriptionClient, SubscriptionModels } from 'azure-arm-resource'; | ||
| import * as opn from 'opn'; | ||
| import * as vscode from 'vscode'; | ||
| import * as ContainerModels from '../../node_modules/azure-arm-containerregistry/lib/models'; | ||
| import { AzureAccount, AzureSession } from '../../typings/azure-account.api'; | ||
| import * as acrTools from '../../utils/Azure/acrTools'; | ||
| import { AzureCredentialsManager } from '../../utils/azureCredentialsManager'; | ||
| import { NodeBase } from './nodeBase'; | ||
|
|
||
| /* Single TaskRootNode under each Repository. Labeled "Build Tasks" */ | ||
| export class TaskRootNode extends NodeBase { | ||
| constructor( | ||
| public readonly label: string, | ||
| public readonly contextValue: string, | ||
| public subscription: SubscriptionModels.Subscription, | ||
| public readonly azureAccount: AzureAccount, | ||
| public registry: ContainerModels.Registry, | ||
| public readonly iconPath: any = {} | ||
| ) { | ||
| super(label); | ||
| } | ||
|
|
||
| public name: string; | ||
|
|
||
| public getTreeItem(): vscode.TreeItem { | ||
| return { | ||
| label: this.label, | ||
| collapsibleState: vscode.TreeItemCollapsibleState.Collapsed, | ||
| contextValue: this.contextValue, | ||
| iconPath: this.iconPath | ||
| } | ||
| } | ||
|
|
||
| /* Making a list view of BuildTaskNodes, or the Build Tasks of the current registry */ | ||
| public async getChildren(element: TaskRootNode): Promise<BuildTaskNode[]> { | ||
| const buildTaskNodes: BuildTaskNode[] = []; | ||
| let buildTasks: ContainerModels.BuildTask[] = []; | ||
|
|
||
| const client = AzureCredentialsManager.getInstance().getContainerRegistryManagementClient(element.subscription); | ||
| const resourceGroup: string = acrTools.getResourceGroup(element.registry); | ||
|
|
||
| buildTasks = await client.buildTasks.list(resourceGroup, element.registry.name); | ||
| if (buildTasks.length === 0) { | ||
| vscode.window.showInformationMessage(`You do not have any Build Tasks in the registry, '${element.registry.name}'. You can create one with ACR Build. `, "Learn More").then(val => { | ||
| if (val === "Learn More") { | ||
| opn('https://aka.ms/acr/buildtask'); | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| for (let buildTask of buildTasks) { | ||
| let node = new BuildTaskNode(buildTask.name, "buildTaskNode"); | ||
| buildTaskNodes.push(node); | ||
| } | ||
| return buildTaskNodes; | ||
| } | ||
| } | ||
|
|
||
| export class BuildTaskNode extends NodeBase { | ||
|
|
||
| constructor( | ||
| public readonly label: string, | ||
| public readonly contextValue: string, | ||
|
There was a problem hiding this comment. where do you use the contextValue? There was a problem hiding this comment. Nowhere yet, but later we will link the BuildTaskNode to open the corresponding log |
||
| ) { | ||
| super(label); | ||
| } | ||
| } | ||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably standardize the icon names/ paths, there is a file under utils called constants which would be helpful for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we need that since for each image, iconPath (light and dark) is only called once in the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is true but it is easier to refactor/change images from a single location, this is better practice and makes for a more unified experience, moving them all out would make the codebase neater. This isn't however pressing and should be done on further refactorings and doesn't really fit in this scope.