Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] LEGO Control+ image #296

Merged
merged 6 commits into from May 8, 2022
Merged

[Feat] LEGO Control+ image #296

merged 6 commits into from May 8, 2022

Conversation

davmacario
Copy link
Member

@davmacario davmacario commented Apr 5, 2022

Contributes to #161

πŸ“‘ Description

βœ… Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

β„Ή Additional Information

@gmacario gmacario changed the title Lego control+ image [Feat] Lego control+ image Apr 5, 2022
@gmacario gmacario added this to the dev-cw14 milestone Apr 5, 2022
@gmacario gmacario added the enhancement New feature or request label Apr 5, 2022
@gmacario
Copy link
Member

gmacario commented Apr 5, 2022

Thank you @davmacario for your first contribution.

It looks 90% OK. To achieve 100% score and be merged would you be able to create a markdown page where this image is inserted which explains how this program is supposed to work?

You may take inspiration from https://github.com/B-AROL-O/ARNEIS/tree/main/code/poweredupapp-flash-move

Once you do that, this HOWTO may be featured in the official set of HOWTOs at https://arneis.readthedocs.io

@gmacario gmacario changed the title [Feat] Lego control+ image [Feat] LEGO Control+ image Apr 5, 2022
@gmacario gmacario self-requested a review April 5, 2022 16:17
Copy link
Member

@gmacario gmacario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a page /docs/howto/howto-xxxx.md (choose xxxxx based on the actual contents of the page) which includes this image and describes:

  1. What this program is supposed to do
  2. Which are the prerequisites (i.e. which motors have to be connected where)
  3. Shows how it works in practice
  4. etc.

@davmacario
Copy link
Member Author

As I was going to update the documentation I realized I don't remember precisely where the motors are attached, but since I'm isolated in my room due to covid reasons I am not able to look at the prototype of the conveyor belt and cannot find any images of the final prototype (the one which appeared in the video-presentation) in thee ARNEIS repo...

@gmacario
Copy link
Member

gmacario commented Apr 7, 2022

I am not able to look at the prototype of the conveyor belt and cannot find any images of the final prototype

You may always ask for help to someone else who knows this information, such as @filmacario

@gmacario gmacario added the help wanted Extra attention is needed label Apr 8, 2022
@gmacario gmacario modified the milestones: dev-cw14, dev-cw15, dev-cw16 Apr 10, 2022
@gmacario gmacario modified the milestones: dev-cw16, dev-cw17 Apr 24, 2022
@gmacario gmacario modified the milestones: dev-cw17, dev-cw18 May 1, 2022
@gmacario
Copy link
Member

gmacario commented May 8, 2022

Merging as-is, will deal with HOWTO page creating in a future PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants