Make macOS CI more robust to changes in the SystemC library #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub VMs for macOS 12 and 13 are now installing SystemC compiled with a newer C++ standard than C++11. This causes the testsuite to fail to link, because we have hardcoded the flag '-std=c++11'. In fact, the macOS 12 VM seems to sometimes install a library using C++11 and sometimes using C++17. To account for this, identify the flag to use by looking at the symbols in the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testsuite is failing with issue #557 again. To address that issue, we made the macOS CI workflow add the flag
-std=c++11for SystemC tests, since the SystemC library was compiled that way. However, it now seems that the SystemC library on macOS 12 and 13 is compiled for C++17. (For the macOS 12 VM, it varies! Sometimes it still installs SystemC compiled for C++11!) I can't identify what changed, but it presumably happened in the last two weeks: The CI for PR #660 passed two weeks ago, but failed today when merged.To make the testsuite more robust to changes in the SystemC standard, this PR looks at the symbols in the SystemC library, to identify which flag is needed for linking.