Fix Bluetcl use of GHC macros, for older GHC #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The __GLASGOW_HASKELL_FULL_VERSION__ CPP macro was introduced in 9.0, so for earlier versions, we need to construct it from other macros that have existed since at least 7.10.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to record the GHC version in Bluetcl use the
__GLASGOW_HASKELL_FULL_VERSION__CPP macro. The GHC docs are misleading and can be interpreted as suggesting that this macro has been around since 7.10, but actually it was introduced in 9.0. (It is other macros mentioned below it that have been around since 7.10.) For older GHC, we can construct the version from other macros (that have been around since at least 7.10).