Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XFCE panel remains unthemed #4

Closed
swidi opened this issue Dec 6, 2017 · 33 comments
Closed

XFCE panel remains unthemed #4

swidi opened this issue Dec 6, 2017 · 33 comments
Assignees

Comments

@swidi
Copy link

swidi commented Dec 6, 2017

img

Amazing theme, but sadly the panel is not correctly themed. It has the window background color instead of the correct background image and the window buttons are themed like normal buttons

@Elbullazul
Copy link
Member

will work on it when I get time to do it

@s3boun3t
Copy link

s3boun3t commented Jul 19, 2018

yes me too on xubuntu 18.04
please fix it
img

thanks

@Elbullazul
Copy link
Member

since all of b00merang's themes are affected, we'll work on a general fix soon

@s3boun3t
Copy link

thanks for the quick answers

@mason1920
Copy link

The panel still remains unthemed.

@xmbv
Copy link

xmbv commented Jan 29, 2019

Is this project still being maintained? This issue still remains after over a year.

@joakim-i
Copy link

Hi, this is still not fixed :( Any update on it? I saw latest commit was 5 days ago and I hope you didnt forget this

@Elbullazul
Copy link
Member

I can fix it this week but may not be prefect in the first try. At least i have the code to theme the panel correctly

@Elbullazul Elbullazul changed the title XFCE panel remains uthemed XFCE panel remains unthemed Jun 16, 2019
@Elbullazul
Copy link
Member

e78dcb6 adds full support:

VirtualBox_Xubuntu 19 04_16_06_2019_11_54_06

@joakim-i
Copy link

joakim-i commented Jun 16, 2019

Perfect! Just one final question for you :)

Do you have any possible remedy for the issue you can see on my panel with the white ugly coloring?

img

@Elbullazul
Copy link
Member

@Telavus what Xfce version are you on and on what distro? (name and version)

@joakim-i
Copy link

@Elbullazul Manjaro (Rolling release) XFCE Version 4.13

@joakim-i
Copy link

joakim-i commented Jun 18, 2019

Mind you: The Luna theme seems to be working fine with color schemes, its specifically the Embedded and Royale / Royale Noir themes. Also the embedded theme atleast should have white text in the panels (if you intend for the themes to be faithful to the original themes for Windows)

Thanks for you work and I hope you have time to fix this :)

@demonidios
Copy link

Elbullazul, The Luna theme in XFCE 4.12/4.14(XUbuntu 19.04/19.10/20.04) has an incorrect appearance in the tray and does not match the appearance of the original Windows XP theme. If you give an email, then I can send a more detailed description of the observed inconsistencies and discrepancies.

@Elbullazul
Copy link
Member

You can post it here. Please include screenshots as well

@demonidios
Copy link

Elbullazul_1

No. 1,2,3 - the color does not match. The original Windows XP “Luna” theme has shades of blue, and you have light gray everywhere.
Circled in green. The “Start” button (in Russian - “Pusk”) - in the original theme it is green, dimensions - height - 30 pixels, length - 107 pixels. If necessary, I can send images in png format of the right size.
Circled in red. The icon, when you click on it, you get to the window with the buttons for rebooting, shutting down, sleeping and changing users - you have it green with white arrows, but should be red, as in the original theme.

@demonidios
Copy link

image

The “Start” button (in Russian - “Pusk”) - in the original theme it is green, dimensions - height - 30 pixels, length - 107 pixels. When you hover over the cursor from dark blue, it becomes light blue. Must be green.
In the theme “Redmond97” (the theme for Windows 98), the theme developer has made the appearance settings of the “Start” button into a separate file called whisker-menu.css. In the gtk.css file, it is loaded through the following command: “@import url (" whisker-menu.css "); ".
Download, look, maybe something will come in handy from what he applied for his topic.
Link - https://github.com/matthewmx86/Redmond97

@demonidios
Copy link

image

Discrepancy of appearance of tray. It is possible that it will be more precisely called Taskbar Notification Area or System tray. In your theme, tray, like the entire panel, is dark blue. When you hover over any indicator, its background takes on a color of light blue, while the strips of dark blue remain above and below. In the original “Luna” theme, all indicators (prome of the keyboard layout indicator) in the tray are located against a light blue background, as in the image, and when you hover over them, only a message (tooltip) pops up, the indicator does not stand out anymore. The keyboard layout indicator remains on a dark blue background, when you hover over it, it is highlighted in the form of a square of the same color protruding above the surface of the panel (maybe I didn’t put it that way, so I’ll apologize for a possible misunderstanding. If that, pay attention to what the “Start” button looks like in the topic “Redmond97).

@demonidios
Copy link

I would like the corrected topic to be posted for use as quickly as possible, but I understand that you have more important matters. Christian, and for help on what issues related to the XUbuntu operating system can I contact you?

@demonidios
Copy link

I could fix the problem with the icons on the button myself.
To change the icon of the "Exit" button in the xfce-menu application menu, you need to log as root in /usr/share/icons/Windows-XP-master/24x24/actions/ and name the system-log-out file with the desired icon.
The icon of the reboot button changes to /usr/share/icons/Windows-XP-master/32x32/actions/ by adding a file with the desired image and assigning it the desired name.

@Elbullazul
Copy link
Member

Elbullazul commented Feb 11, 2020

Hello,

Thanks for the redmond link,might be useful.

I can't push your icon change because it's the action that is different. In xp you had a shutdown button. In xfce you have a logout button.

Panel theming for xfce is a pain because there is no fixed layout or guideline that I know of to theme it like other panels (cinnamon, gnome). Maybe I find something that helps in the redmond repo?

I'm currently employed full time and may not be able to work on this for a couple of months. However, I'll try my best to find some time to at least try to fix it before then.

Regards,

@demonidios
Copy link

@demonidios
Copy link

Elbullazul_2

@demonidios
Copy link

Elbullazul_3

@demonidios
Copy link

All this is the same for XUbuntu 19.04 / 19.10 / 20.04

@demonidios
Copy link

Look here. Then the theme creator was able to figure out the Whisker-Menu button and the appearance of the panel and the menu itself.
Prowler EX WhiskerMenu and Panel theme GTK3 XFCE 4.14
https://www.xfce-look.org/p/1355567/

@Elbullazul
Copy link
Member

tried some things, but results weren't satisfying enough for me. menu background is feasible, but I can't have it scale and there's no apparent zone separation for me to theme portions of the menu.

the start menu fix looked decent, but may not be released until next month

@demonidios
Copy link

Hello Christian! Could you make the necessary changes? In the last message from 04/23/2020 you write that you are implementing a new design theme with corrections no earlier than the next month. Is it already available for download and use, or do you still have to wait?

@Elbullazul
Copy link
Member

@demonidios it's available in the master branch, haven't made a release yet

@demonidios
Copy link

Downloaded from the master branch. Nothing has changed. Either you forgot to add changes, or you just didn’t succeed.

@Elbullazul
Copy link
Member

my bad, didn't remember what changes you asked for.

I'll try to have the app menu button look like in Windows XP, but the tray area, I'm afraid I can't do that yet. At least, not until Xfce finishes migrating to GTK3

@Elbullazul
Copy link
Member

Also, I'm going to open a new issue for this matter, please use that one for further discussion (I'll post the link)

@Elbullazul
Copy link
Member

#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants