HTM-1032: Disable CSRF filter for FeaturesController #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for idempotent request large filter in body) so it can be used when in an iframe
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
=======================================
+ Coverage 6% 77% +72%
Complexity 78 78
=======================================
Files 88 88
Lines 3810 3811 +1
Branches 378 378
=======================================
+ Hits 194 2929 +2735
+ Misses 3597 687 -2910
- Partials 19 195 +176
|
mprins
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FeaturesControler only uses POST for an idempotent request because the filter can possibly be too large for a URL query parameter so with a POST request the filter can be sent in the request body. Disable CSRF protection for this controller so feature info requests etc. can be used when Tailormap is embedded an iframe when the XSRF token can't be read from the 3rd party cookie (even with SameSite=None, with strict browser protection settings this is still blocked by some current browsers which have those by default).