Improve options typing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepakriz
changed the title
pepakriz
force-pushed
the
logger-is-required
branch
from
9c75d4c
to
0e76364
Compare
pepakriz
changed the title
pepakriz
force-pushed
the
logger-is-required
branch
from
0e76364
to
4c8f4e5
Compare
Pull Request Test Coverage Report for Build 35
💛 - Coveralls |
B4nan
reviewed
Jan 11, 2019
lib/EntityFactory.ts
Outdated
|
|
||
| const project = new Project(); | ||
| const sources: SourceFile[] = []; | ||
|
|
||
| if (!this.em.options.entitiesDirsTs) { |
There was a problem hiding this comment.
what is wrong with this? it is a problem when you enable more strict TS settings? i like to use this falsy comparison as its imho more readable and it is usually more accurate than strict check against undefined (what if you provide null, empty string, zero... still not valid but passes the condition).
B4nan
reviewed
Jan 11, 2019
B4nan
reviewed
Jan 11, 2019
B4nan
reviewed
Jan 11, 2019
pepakriz
force-pushed
the
logger-is-required
branch
from
4c8f4e5
to
87e54c8
Compare
|
@B4nan it's ready to merge. A lot of thinks was removed, so PR is only about better Options typing. Next time I'll try to make smaller and more indipendent PRs. BTW because the code coverage has been decreased (-0.01% 😄), PR is marked as failing. Is it necessary? |
|
I guess that is just because you removed some tested code, don't worry about that :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.