Skip to content

Commit

Permalink
Introdced logging of warnings and proper treatment of missing 'powerS…
Browse files Browse the repository at this point in the history
…tate' attribute
  • Loading branch information
Marc committed Feb 24, 2021
1 parent d069c20 commit 6a4bec1
Showing 1 changed file with 24 additions and 4 deletions.
28 changes: 24 additions & 4 deletions hassfeld/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ def log_info(message):
logger.info(message)


def log_warn(message):
"""Logging of warnings."""
logger.warning(message)


def log_critical(message):
"""Logging of information."""
logger.critical(message)
Expand Down Expand Up @@ -214,9 +219,16 @@ def __update_zone_config(self, content_xml):
room_udn = room_itm["@udn"]
zone_rooms.append(room_name)
self.lists["rooms"].append(room_name)
self.resolve["roomudn_to_powerstate"][room_udn] = room_itm[
"@powerState"
]
if "@powerState" in room_itm:
self.resolve["roomudn_to_powerstate"][room_udn] = room_itm[
"@powerState"
]
else:
log_warn(
"No 'powerState' attribute provided for room: %s"
% room_name
)
self.resolve["roomudn_to_powerstate"][room_udn] = None
self.resolve["room_to_udn"][room_name] = room_udn
self.resolve["udn_to_room"][room_udn] = room_name
self.resolve["zoneudn_to_roomudnlst"][zone_udn].append(room_udn)
Expand All @@ -227,7 +239,15 @@ def __update_zone_config(self, content_xml):
for room in self.wsd["zone_config"]["unassignedRooms"]["room"]:
room_name = room["@name"]
room_udn = room["@udn"]
self.resolve["roomudn_to_powerstate"][room_udn] = room["@powerState"]
if "@powerState" in room:
self.resolve["roomudn_to_powerstate"][room_udn] = room[
"@powerState"
]
else:
log_warn(
"No 'powerState' attribute provided for room: %s" % room_name
)
self.resolve["roomudn_to_powerstate"][room_udn] = None
self.resolve["room_to_udn"][room_name] = room_udn
self.resolve["udn_to_room"][room_udn] = room_name
self.lists["rooms"].append(room_name)
Expand Down

0 comments on commit 6a4bec1

Please sign in to comment.