Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some Windows bugs and tweak docs #134

Merged
merged 7 commits into from
Jan 27, 2021
Merged

Fix some Windows bugs and tweak docs #134

merged 7 commits into from
Jan 27, 2021

Conversation

carise
Copy link
Contributor

@carise carise commented Jan 23, 2021

Windows bugs

Other

  • The coverage tool associated with this repo was for when this repo was named adam. I've changed the build script to push coverage results to codecov and updated the coverage badge accordingly.
  • Add a missing parameter from documentation. (Will regenerate documentation in separate PR)
  • Added more virtual environments to run CI in

@github-actions
Copy link

Locust summary

Git references

Initial: 45c50a9
Terminal: 83e434c

adam/opm_params.py
Changes:
  • Name: OpmParams
    Type: class
    Changed lines: 1
    Total lines: 383
    Changes:
adam/config_manager.py
Changes:

@B612-Asteroid-Institute B612-Asteroid-Institute deleted a comment from codecov bot Jan 23, 2021
@codecov
Copy link

codecov bot commented Jan 25, 2021

Codecov Report

Merging #134 (e6964ac) into master (45c50a9) will decrease coverage by 0.05%.
The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   63.76%   63.71%   -0.06%     
==========================================
  Files          27       27              
  Lines        2012     2020       +8     
==========================================
+ Hits         1283     1287       +4     
- Misses        729      733       +4     
Impacted Files Coverage Δ
adam/__main__.py 0.00% <0.00%> (ø)
adam/opm_params.py 93.06% <ø> (ø)
adam/config_manager.py 58.33% <83.33%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c50a9...e6964ac. Read the comment docs.

@carise carise changed the title Fix the config manager file renaming for Windows and tweak docs Fix some Windows bugs and tweak docs Jan 26, 2021
… Linux and Mac but doesn't seem to work in Windows, unless specified in the conda recipe.
@carise carise merged commit 86bcd05 into master Jan 27, 2021
@carise carise deleted the cf-config-manager branch January 27, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants