Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc welding processes #104

Merged
merged 20 commits into from Aug 27, 2020
Merged

Arc welding processes #104

merged 20 commits into from Aug 27, 2020

Conversation

CagtayFabry
Copy link
Member

Add base arc welding process classes and schema

@CagtayFabry CagtayFabry added the ASDF everything ASDF related (python + schemas) label Aug 11, 2020
@CagtayFabry CagtayFabry self-assigned this Aug 11, 2020
@pep8speaks
Copy link

pep8speaks commented Aug 11, 2020

Hello @CagtayFabry! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-08-27 15:25:20 UTC

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #104 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          62       63    +1     
  Lines        3070     3106   +36     
=======================================
+ Hits         3068     3104   +36     
  Misses          2        2           
Impacted Files Coverage Δ
weldx/asdf/utils.py 100.00% <ø> (ø)
weldx/__init__.py 100.00% <100.00%> (ø)
weldx/asdf/tags/weldx/core/time_series.py 100.00% <100.00%> (ø)
weldx/welding.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7b9e9f...c72074d. Read the comment docs.

@CagtayFabry CagtayFabry marked this pull request as ready for review August 21, 2020 10:00
@vhirtham vhirtham merged commit e8c7a2b into master Aug 27, 2020
@CagtayFabry CagtayFabry deleted the arc_welding_processes branch September 2, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants