Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated normalized argument in from_quat signature #224

Merged
merged 15 commits into from Jan 25, 2021

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented Jan 13, 2021

Changes

update for scipy deprecations, restrict scipy<1.6 due to asdf-format/asdf#916

Related Issues

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #224 (b92c35d) into master (e1b5532) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   99.84%   99.84%   -0.01%     
==========================================
  Files          70       70              
  Lines        3915     3910       -5     
==========================================
- Hits         3909     3904       -5     
  Misses          6        6              
Impacted Files Coverage Δ
weldx/__init__.py 100.00% <ø> (ø)
weldx/transformations.py 99.38% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b5532...b92c35d. Read the comment docs.

@CagtayFabry CagtayFabry marked this pull request as ready for review January 13, 2021 15:42
@CagtayFabry
Copy link
Member Author

should be fixed now for scipy<1.6 at least @vhirtham

@vhirtham vhirtham linked an issue Jan 20, 2021 that may be closed by this pull request
@CagtayFabry
Copy link
Member Author

It's curious why the Windows pytest run is passing even with the error.. Any idea @vhirtham ?

@vhirtham
Copy link
Collaborator

vhirtham commented Jan 20, 2021

It's curious why the Windows pytest run is passing even with the error.. Any idea @vhirtham ?

@CagtayFabry working on it. I am currently installing everything on my private Ubuntu system to test it

@CagtayFabry CagtayFabry self-assigned this Jan 22, 2021
@CagtayFabry
Copy link
Member Author

I say we leave it at that for now @vhirtham ?
Can you do a quick review?

@CagtayFabry CagtayFabry added the bug Something isn't working label Jan 22, 2021
@CagtayFabry CagtayFabry merged commit 60fb362 into master Jan 25, 2021
@CagtayFabry CagtayFabry deleted the from_quat_signature branch January 25, 2021 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SciPy 1.6 breaks WXRotations
2 participants