Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort csm subsystem lists #430

Merged
merged 7 commits into from Jul 16, 2021
Merged

Conversation

vhirtham
Copy link
Collaborator

@vhirtham vhirtham commented Jul 16, 2021

Changes

Sort string lists before storing them in a WelDX file

Related Issues

Closes #423

Checks

  • updated CHANGELOG.md
  • updated tests
  • updated doc/
  • update example/tutorial notebooks

@vhirtham vhirtham added the ASDF everything ASDF related (python + schemas) label Jul 16, 2021
@vhirtham vhirtham self-assigned this Jul 16, 2021
@pep8speaks
Copy link

pep8speaks commented Jul 16, 2021

Hello @vhirtham! Thanks for updating this PR.

Line 474:26: E231 missing whitespace after ':'
Line 474:26: E999 SyntaxError: invalid syntax
Line 474:28: E251 unexpected spaces around keyword / parameter equals

Comment last updated at 2021-07-16 11:53:00 UTC

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #430 (99df739) into master (a142185) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   97.25%   97.26%           
=======================================
  Files          87       87           
  Lines        5400     5411   +11     
=======================================
+ Hits         5252     5263   +11     
  Misses        148      148           
Impacted Files Coverage Δ
...ore/transformations/coordinate_system_hierarchy.py 100.00% <100.00%> (ø)
weldx/asdf/util.py 84.34% <100.00%> (+1.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a142185...99df739. Read the comment docs.

@vhirtham
Copy link
Collaborator Author

I adjusted the CSM serialization and our weldx.asdf.util.dataclass_serialization_class function. That should cover most cases. Didn't find any further corresponding type hints in the asdf directory and searching for

type: array
    items:
      type: string

in the schemas only brought up an additional case in the CSM I missed initially. I guess we covered everything.

@vhirtham vhirtham marked this pull request as ready for review July 16, 2021 11:40
@vhirtham vhirtham merged commit 699e4e2 into BAMWelDX:master Jul 16, 2021
@vhirtham vhirtham deleted the 423_string_lists branch July 16, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sort string list output in asdf tree
3 participants