Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set networkx<=2.8.0 #761

Merged
merged 2 commits into from May 19, 2022
Merged

set networkx<=2.8.0 #761

merged 2 commits into from May 19, 2022

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented May 19, 2022 •
edited

Changes

set networkx<=2.8.0 until CSM deepcopy is resolved
see: https://github.com/BAMWelDX/weldx/runs/6502339152?check_suite_focus=true#step:9:110

Checks

  • updated CHANGELOG.rst

@CagtayFabry CagtayFabry added the dependencies changes in package dependencies label May 19, 2022
@codecov
Copy link

codecov bot commented May 19, 2022 •
edited

Codecov Report

Merging #761 (fca56ce) into master (b6e9a33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   96.86%   96.86%           
=======================================
  Files          88       88           
  Lines        6005     6005           
=======================================
  Hits         5817     5817           
  Misses        188      188

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6e9a33...fca56ce. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 19, 2022 •
edited

Unit Test Results

       1 files  ±0         1 suites  ±0   2m 36s ⏱️ -41s
2 152 tests ±0  2 152 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fca56ce. ± Comparison against base commit b6e9a33.

♻️ This comment has been updated with latest results.

@CagtayFabry CagtayFabry merged commit bab2c5d into BAMWelDX:master May 19, 2022
@CagtayFabry CagtayFabry deleted the fix_networkx branch May 19, 2022 08:20
@marscher
Copy link
Collaborator

networkx/networkx#2793 might be related, but is from 2017

@CagtayFabry
Copy link
Member Author

looks like that could be related, yes

I don't really know what the cause is, if you do deepcopy(csm) it fails but deepcopy(csm._graph) seems to work

@marscher
Copy link
Collaborator

that is indeed super weird.

@marscher
Copy link
Collaborator

G.edges access also triggers the error, so it is completely unrelated to deepcopy, or pickle.

marscher added a commit that referenced this pull request May 21, 2022
@marscher
Revert "set networkx<=2.8.0 (#761)"
3a14d4b 
This reverts commit bab2c5d.
@marscher marscher mentioned this pull request May 21, 2022
Merged
marscher added a commit that referenced this pull request May 31, 2022
@marscher
Revert "set networkx<=2.8.0" (#763)
ceaa4c5 
* Revert "set networkx<=2.8.0 (#761)"

This reverts commit bab2c5d.

* pin nx != 2.8.1

networkx-2.8.2 fixed the deepcopy bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marscher marscher marscher approved these changes

Assignees
No one assigned
Labels
dependencies changes in package dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CagtayFabry @marscher