Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pint 0.21 related errors #876

Merged
merged 5 commits into from May 10, 2023
Merged

Conversation

CagtayFabry
Copy link
Member

@CagtayFabry CagtayFabry commented May 9, 2023

Changes

  • compatibility with pint=0.21 and earlier versions
  • add units to some newly supported numpy functions

Related Issues

closes #872

Checks

  • updated CHANGELOG.md
  • updated tests/

@github-actions
Copy link

github-actions bot commented May 9, 2023

Test Results

2 189 tests  ±0   2 188 ✔️ +125   3m 3s ⏱️ + 1m 1s
       1 suites ±0          1 💤 ±    0 
       1 files   ±0          0  - 125 

Results for commit ee167b3. ± Comparison against base commit c2ee9b1.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #876 (ee167b3) into master (c2ee9b1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #876   +/-   ##
=======================================
  Coverage   96.51%   96.51%           
=======================================
  Files          94       94           
  Lines        6283     6283           
=======================================
  Hits         6064     6064           
  Misses        219      219           
Impacted Files Coverage Δ
weldx/geometry.py 96.62% <100.00%> (ø)

@CagtayFabry CagtayFabry mentioned this pull request May 10, 2023
5 tasks
@CagtayFabry CagtayFabry added units unit handling and pint dependencies changes in package dependencies labels May 10, 2023
@CagtayFabry
Copy link
Member Author

I looked into the mypy errors but could not figure out what the best way to implement type hints is now

Unfortunately the documentation for this is lacking in pint, so leaving as is for now (mypy passes with pint=0.20)

@CagtayFabry CagtayFabry marked this pull request as ready for review May 10, 2023 08:47
@CagtayFabry CagtayFabry merged commit 7b5c0c1 into BAMWelDX:master May 10, 2023
28 of 30 checks passed
@CagtayFabry CagtayFabry deleted the fix_pint_021 branch May 10, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies changes in package dependencies units unit handling and pint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests failing with pint 0.21
1 participant