Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWL: demonstrate use of conda suggestions #42

Merged
merged 3 commits into from May 11, 2022
Merged

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Apr 19, 2022

Allows each step to use a different conda environment and the selection
of conda packages that are not co-installable.

I can also send a PR to replace prepare_paper_macros.cwl with an inline file creation as part of compile_paper.cwl, if desired

Allows each step to use a different conda environment and the selection
of conda packages that are not co-installable.
Copy link
Member

@joergfunger joergfunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the comments. Could you adapt the github actions such that the different conda environments are directly tested. In particular for paraview, there might be some modifications required.

simple_use_case/cwl/convert_msh_to_xdmf.cwl Show resolved Hide resolved
simple_use_case/cwl/README.md Show resolved Hide resolved
simple_use_case/cwl/make_paraview_plot.cwl Show resolved Hide resolved
@mr-c
Copy link
Contributor Author

mr-c commented Apr 20, 2022

FYI, for best results, perhaps there should be materials testing & research version of biocontainers.org ; a service that automatically creates software containers based upon (bio)conda packages (and other sources). Everything is open source and I'd be happy to introduce you all to the team

.github/workflows/main.yml Outdated Show resolved Hide resolved
@dglaeser
Copy link
Collaborator

dglaeser commented May 3, 2022

FYI, for best results, perhaps there should be materials testing & research version of biocontainers.org ; a service that automatically creates software containers based upon (bio)conda packages (and other sources). Everything is open source and I'd be happy to introduce you all to the team

@mr-c, so you mean instead of using the conda actions in the CI, we may use that service to automatically let them create and host images for us (and use these in the CI)? This sounds interesting!

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@mr-c
Copy link
Contributor Author

mr-c commented May 4, 2022

@dglaeser My guess is that there is something in the GitHub Actions environment for Ubuntu causing problems;

A colleague suggested using https://github.com/mxschmitt/action-tmate to debug the situation by enabling SSHing into the runner itself.

just make sure to also secure it if you don't want people watching you 😉
(limit-acces-to-actor)

It will be a bit tricky, as there isn't much debugging output for using --beta-conda-dependencies

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@dglaeser
Copy link
Collaborator

dglaeser commented May 9, 2022

@joergfunger, the actions work now. I am ok with the PR, but there are two open threads that were raised by you. Would you mind double-checking them? !

@dglaeser dglaeser merged commit 4f6c5e3 into BAMresearch:main May 11, 2022
@mr-c mr-c deleted the cwl_conda branch October 23, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants