Fix gestures and sleep problem + Cleanup

[hieplpvip]

Hi, this pull request fixes trackpad not working after sleep by calling resetMouse() upon waking.

I also fix some indentations/spaces and reorder the files so that they're sorted alphabetically.

[hieplpvip]

Commit 7051549 should fix this issue

Gestures work on V1 because there was a null check for tp_dev. On Linux, tp_dev is initialized when has_trackpoint is true. You removed the check for tp_dev but forgot to replace it with a check for has_trackpoint.

Anyway, thank you very much for your great work!

[hieplpvip]

VoodooPS2Controller-2.1.7-RELEASE.zip
VoodooPS2Controller-2.1.7-DEBUG.zip

Prebuilt for anyone wanting to test this (built from commit 90b8a33)

[Sher1ocks]

@hieplpvip oh my god! you save me. it's perfect. finally, i got elan ps2.

For 5 years I only used the smarttouchpadps2 driver

No problem after sleeping
and gesture too.
Your code is I wish I could be included in https://github.com/acidanthera/VoodooPS2
It can be used as a daily driver enough for now.
Thank you so much you saved me

[hieplpvip]

The major work of porting the driver was done by @BAndysc. I only fixed some issues. I can create a pull request at acidanthera/VoodooPS2 right away, but it would seem like I take all his credit. It's more appropriate that he merges this pull request and pushes his work upstream himself.

Still, @BAndysc has been inactive since the end of July. Acidanthera's next release cycle is on October 5. If he is still inactive by that time, I would push this upstream myself. I think the driver is mature enough for daily use.

[Sher1ocks]

The major work of porting the driver was done by @BAndysc. I only fixed some issues. I can create a pull request at acidanthera/VoodooPS2 right away, but it would seem like I take all his credit. It's more appropriate that he merges this pull request and pushes his work upstream himself.

Still, @BAndysc has been inactive since the end of July. Acidanthera's next release cycle is on October 5. If he is still inactive by that time, I would push this upstream myself. I think the driver is mature enough for daily use.

yes. you are right. "The major work of porting the driver was done by @BAndysc."
also i will contact him.

do you have led capslock issue in LG GRAM 14Z970?
my capslock led is gone. no led turn on.

[hieplpvip]

Mine is 13Z970. No problems with capslock led

[Sher1ocks]

Mine is 13Z970. No problems with capslock led

i found issue.
after boot, english is default, capslock led is working. but change en to kr. capslock led is gone.
i turn off "capslock key change ABC alphabet."

[Sher1ocks]

Mine is 13Z970. No problems with capslock led

capslock led issue summary

#1.turn off option. "Use The Caps Lock key to switch to and ABC"
1 case.
-> after boot, default capslock led is off.
-> default english, capslock led is no problem. turn on/off is good.
-> only english, everything fine.
2 case.
-> after boot, default capslock led is off.
-> default english, change en to kr, capslock led is gone. never capslock led on again.
3 cases.
-> after boot, default capslock led is off.
-> default english, press capslock(led on), then change en to kr, always capslock led is on.

as result, when using two language, capslock led is not properly working.

#2. turn on option. "Use The Caps Lock key to switch to and ABC"
everything is good.

[Sher1ocks]

@hieplpvip my physical button is not good in latest version.
very strange. just button click not click, just show mutil windows. also scroll is not good when entering physicall button not work. i'm using lg gram touchpad what you know

[Sher1ocks]

after use buttonclick, sometimes happen issue. if click word with buttonclick on safari, showing dicitionary. except buttonclick, there is no problem.

[hieplpvip]

@Sher1ocks The click issue is actually Force Touch emulation. You can turn it off in System Preferences/Trackpad/Force Click and haptic feedback

[Sher1ocks]

@hieplpvip
also right buttonclick is not working
uncheck / tap click in SP/Trackpad
uncheck / Force Click and haptic feedback

seems my touchpad changed one button clickpad

[hieplpvip]

@Sher1ocks Please test it

[Sher1ocks]

@Sher1ocks Please test it

not work

[hieplpvip]

@Sher1ocks Please test again. It should work now

[Sher1ocks]

@Sher1ocks Please test again. It should work now

still not work

[hieplpvip]

I have no idea why it's not working for you. I've reverted changes related to right button click. Are you sure it used to work before?

[aviwad]

amazing! palm rejection works great now! i see the touchpad is blocked from responding 1/2 seconds after the keyboard is used. clever.

[Sher1ocks]

@hieplpvip
i checked all version since BAandysc's first verion.
first version also right button is not working.
only recoginzed one button.

Smarttouchpad kext is no problem right button.

[Sher1ocks]

@hieplpvip are you working right button in 13Z970?
now, if use only two finger tap, show right menu.

in recovery, only working left button.

right button is left button. as result, my touchpad is one button now.

EDIT1.
also force touch emulation, if use clickpad, always force touch.
can you more consider case if check forceclick hapic feedback?
until check "tap to click", i never access example system preference without usb mouse after install macos

[hieplpvip]

I think we're having some misunderstanding here. You said your laptop is LG gram 14Z970, which should have a clickpad (clickpads are touchpads without separate physical buttons), something like this:

while my fix above is for trackpad with dedicated buttons like this one:

I guess by "right button" you means the bottom right corner of your trackpad?

Well, clicking the "right button" resulting in left click is actually the default and desired behavior on macOS. macOS doesn't distinguish "left" or "right button". The reason behind this design is trackpad on Macbook supports clicking at any point (even at the top), while Windows trackpad only supports clicking at the bottom. Clicking with one finger, no matter where, results in left click. To get right click, click with two fingers.

Personally, I prefer this to the traditional behavior on Windows. It makes the experience much easier and better. (If I'm correct, Windows has adopted this behavior too)

That being said, if you still want to get right click with "right button", you can change the Secondary click setting to Click in bottom right corner

[Sher1ocks]

I think we're having some misunderstanding here. You said your laptop is LG gram 14Z970, which should have a clickpad (clickpads are touchpads without separate physical buttons), something like this:

while my fix above is for trackpad with dedicated buttons like this one:

I guess by "right button" you means the bottom right corner of your trackpad?

Well, clicking the "right button" resulting in left click is actually the default and desired behavior on macOS. macOS doesn't distinguish "left" or "right button". The reason behind this design is trackpad on Macbook supports clicking at any point (even at the top), while Windows trackpad only supports clicking at the bottom. Clicking with one finger, no matter where, results in left click. To get right click, click with two fingers.

Personally, I prefer this to the traditional behavior on Windows. It makes the experience much easier and better. (If I'm correct, Windows has adopted this behavior too)

That being said, if you still want to get right click with "right button", you can change the Secondary click setting to Click in bottom right corner

thank you for clear.
my case 1 you said.

That being said, if you still want to get right click with "right button", you can change the Secondary click setting to Click in bottom right corner
-> checked work. thank you for tip.

i want to know this case.
if use left clickpad, always force touch.
ofc, you gave me tip that "The click issue is actually Force Touch emulation. You can turn it off in System Preferences/Trackpad/Force Click and haptic feedback"

can you more consider case if check forceclick hapic feedback? give some seconds to use The click issue is actually Force Touch emulation?
until check "tap to click", i never access example system preference without usb mouse after install clean macos

for example left clickpad normal click and right click pad force touch emulation.

[Sher1ocks]

i follow this multitouch gesture
https://www.youtube.com/watch?v=Q7vK0uhqLy0
also secondary click not work if use this option

did you test it on your 13z970 gram?

thanks in advance for your hard work

[vit9696]

Hello, can we merge ELAN support upstream? I do not think the changes for ELAN support are too drastic, so it will probably be great to maintain the unified database. I can give commit access to ease the maintenance if necessary.

[Sher1ocks]

i see this video to check trackpad
https://www.youtube.com/watch?v=7HKqJyGN5mI&t=570s

1. two finger for secondary click
   now VoodooELAN, we have to enable "tap to click" for secondary click
   but original trackpad secondary click work without "tap to click"

2. force click and hapic feedback.
   you see this video. just click is working.
   now we have clickpad that always work force click until disable force click in option in VoodooElan.
   force click need pressing click. but our touchpad don't have this.
   it's means if we don't have usb mouse, we never go to setting option on Dock, after install macOS.
   because clickpad always go force click without considering any time or pressing.
   so i suggest, click time. to work for force click, press 1.5sec, or 1 sec with clickpad.

[BAndysc]

@hieplpvip thanks for your contribution. Always nice to see pull requests in open source projects.

@vit9696, @hieplpvip I agree it is mature enough to merge it to the upstream for easier maintenance and reaching wider audience. @vit9696, shall I squash the commits or just send pull request from this branch as it is now?

[vit9696]

@BAndysc I am not positive the history in the branch contains really useful commit messages, so probably it is better to squash in the end. Do not bother doing it on your side though since we could always squash at merging phase (GitHub even has a button for that now). Thanks!

[aviwad]

every once in a while, I use the touchpad while clicking one of the function keys, and the touchpad freezes until I restart. Other than that, amazing!

[hieplpvip]

every once in a while, I use the touchpad while clicking one of the function keys, and the touchpad freezes until I restart. Other than that, amazing!

Maybe you accidentally pressed the PrintScreen key. It's used for toggling the trackpad on/off

[hieplpvip]

@BAndysc Should we disable Force Touch emulation by default (set ForceTouchMode to 0 in Info.plist)?

Synaptics enables it by default, but I'm afraid it can cause confusion for some users.

[BAndysc]

@hieplpvip I think we should stay consistent with master main code, so that possible "problems" and confusions stay consistent between users of different touchpads.