Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: few updates to have the functionality on-par with sentence-transformers and other minor updates #1

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

racinmat
Copy link

@racinmat racinmat commented Apr 15, 2024

This PR adds

I locally ran the code for both local model and downloading from HF hub and it works well.

…d dependency to correspond to newer feature, update target name
@racinmat
Copy link
Author

@BBC-Esq let me know if this PR makes sense to you, and you can merge it so it also gets to the main repo.

@BBC-Esq
Copy link
Owner

BBC-Esq commented Apr 23, 2024

Sorry for the slow response. I won't have time to review this due to work. Are you able to push the lazy blokes at the Instructor repo to accept my pull request and then perhaps you can submit your modification? Alternatively, I'm not sure if it's possible to simply submit your change to them directly even if they're lacy in accepting mine? I'm not a programmer by trade! Chat gpt 4 taught me! ;-)

@racinmat
Copy link
Author

I see, no problem. I'm afraid I'm not able to push them if they are not answering to you.
Yes, I could make a direct PR to them with both changes, and I will do it now, so we'll increase the chance of merging at least one PR.

If you merge this PR, it will add my changes to your PR and thus if they merge all the changes will be there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants