[READY] data-src format
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oncletom So is this proposal literally just automating the If that's what the intent is of this proposal then I think that's a good first start and worth cracking on with. If that's not the intent and there is more work involved then please let me know. |
Conflicts: test/unit/core.js
…ternal dollar and tests Conflicts: test/unit/core.js
- initial tests are failing because the old feature is still working (good way to know the old expectation we are going to break) - new tests are not working because basically it's not done yet
- removed Imager `regex` option
- implemented simple `{width}` interpolation
|
@Integralist I've fixed the typo and made the |
|
@oncletom cool, looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention
Imager is actually quite flexible on the
data-srcpattern as long as you master regular expressions.Also, user needs might be simpler than a RegExp pattern that in most of the case.
The proposal
Controlling the replacement from
data-srcdirectly by using URI Template-like string variables (in fact deeply simplified).From:
To:
{width}is either replaced by any suitableavailableWidthsnumeric value or, by default bydata-width's value.Additional PR will provide
{width}interpolation (to replace by a string value, Flickr or Guardian case) and pixel density adjustement (eventually through a callback to deal with more complex replacement)