Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add babel-plugin-styled-components to all packages #159

Closed
1 task done
ChrisBAshton opened this issue Dec 7, 2018 · 1 comment
Closed
1 task done

Add babel-plugin-styled-components to all packages #159

ChrisBAshton opened this issue Dec 7, 2018 · 1 comment
Assignees
Projects

Comments

@ChrisBAshton
Copy link
Contributor

ChrisBAshton commented Dec 7, 2018

Is your feature request related to a problem? Please describe.

You should definitely use the styled-components Babel plugin.

While removing it doesn't break anything, it makes development a lot nicer by putting the component names into the generated classes, improves performance in production, and enables support for features like the css prop!

See #105 (comment) (thanks, @mxstbr!)

Not all of our packages use babel-plugin-styled-components. As a general rule, we should be adding it to all components (see #162). The components that don't use it will need updating so that they use it, and the snapshot tests will need updating as the class names will be different.

Testing notes
[Tester to complete]

Dev insight: Regression test only.

@ChrisBAshton ChrisBAshton added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. could labels Dec 7, 2018
@ChrisBAshton ChrisBAshton added this to To do in Articles via automation Dec 7, 2018
@ChrisBAshton ChrisBAshton changed the title Consider adding babel-plugin-styled-components to Babel config Add babel-plugin-styled-components to all packages Dec 10, 2018
@ChrisBAshton ChrisBAshton removed this from To do in Articles Jan 7, 2019
@ChrisBAshton ChrisBAshton added this to To do in Simorgh via automation Jan 7, 2019
@rossgaskell rossgaskell moved this from To do to Ready for dev in Simorgh Jun 4, 2019
@rossgaskell rossgaskell added DevX and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. high priority labels Jun 4, 2019
@ryanmccombe ryanmccombe self-assigned this Jun 17, 2019
@ryanmccombe
Copy link
Contributor

ryanmccombe commented Jun 17, 2019

This seems to have already been done: fcea0b5

The issue talks about "adding it to all components" and "updating components that don't use it" - I'm not sure what that means in the context of a babel plugin?

It is configured in the .babelrc at the root of the directory, and is getting used by every styled component:

Screen Shot 2019-06-17 at 11 13 15

This issue seems like it should be closed

@ryanmccombe ryanmccombe moved this from Ready for dev to Done in Simorgh Jun 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

5 participants