Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Bump headings for babel 7 #119

Merged
merged 3 commits into from Dec 5, 2018
Merged

Bump headings for babel 7 #119

merged 3 commits into from Dec 5, 2018

Conversation

dr3
Copy link
Contributor

@dr3 dr3 commented Dec 5, 2018 •
edited

Bump Psammead headings to release as babel 7

Resolves bbc/simorgh#1056

  • Tests added for new features
  • Test engineer approval

@dr3 dr3 self-assigned this Dec 5, 2018
@dr3 dr3 added the alpha-2 label Dec 5, 2018
@dr3 dr3 added this to PR In Progress in Articles via automation Dec 5, 2018
@dr3 dr3 moved this from PR In Progress to 1st Code review in Articles Dec 5, 2018
ChrisBAshton
ChrisBAshton reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you raise an issue in Simorgh which describes the problem, and then #resolve it here? 😄

Otherwise we'll look back at this and try and remember why we did it.

ChrisBAshton
ChrisBAshton approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick work 👍 nice one

@ChrisBAshton ChrisBAshton moved this from 1st Code review to 2nd Code review in Articles Dec 5, 2018
@sareh sareh moved this from 2nd Code review to Test in Articles Dec 5, 2018
@dr3 dr3 merged commit 2319124 into latest Dec 5, 2018
Articles automation moved this from Test to Done Dec 5, 2018
@dr3 dr3 deleted the HeadingsBabel7 branch December 5, 2018 17:11
@ChrisBAshton ChrisBAshton removed this from Done in Articles Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sareh sareh sareh approved these changes

@ChrisBAshton ChrisBAshton ChrisBAshton approved these changes

Assignees

@dr3 dr3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dr3 @sareh @ChrisBAshton