Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix psammead-paragraph styling #134

Merged
merged 5 commits into from Dec 7, 2018
Merged

Fix psammead-paragraph styling #134

merged 5 commits into from Dec 7, 2018

Conversation

bcmn
Copy link
Contributor

@bcmn bcmn commented Dec 7, 2018

Part of #124?

Font size was being imported with T_ prefix, not GEL_ prefix. Doing this fixes the issue described in 124, but there may be additional issues that haven't been captured in that ticket?

Should this block Simorgh#1051?

npm run storybook
visit http://localhost:8080/
Navigate to Paragraph component
View broken styles (on `latest`)
Repeat for this branch `fix_paragraph_styling` Styles should be fixed
  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@bcmn bcmn added this to PR In Progress in Articles via automation Dec 7, 2018
@bcmn bcmn moved this from PR In Progress to 1st Code review in Articles Dec 7, 2018
Copy link
Contributor

@sareh sareh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@bcmn bcmn moved this from 1st Code review to 2nd Code review in Articles Dec 7, 2018
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍 Have added blocked label to #997.

Could you add some explicit test instructions so James knows what we're looking at?

npm run storybook
visit http://localhost:8080/
Navigate to Paragraph component
View broken styles (on `latest`)
Repeat for this branch (styles fixed)

@dr3 dr3 moved this from 2nd Code review to Ready for Test in Articles Dec 7, 2018
@sareh sareh merged commit 3c2453d into latest Dec 7, 2018
Articles automation moved this from Ready for Test to Done Dec 7, 2018
@sareh sareh deleted the fix_paragraph_styling branch December 7, 2018 17:02
@ChrisBAshton ChrisBAshton removed this from Done in Articles Jan 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants