This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Document component approach #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmn
force-pushed
the
document-component-approach
branch
from
8b41c09
to
0704740
Compare
ChrisBAshton
suggested changes
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #137
The readme seems really approachable post-#174, so I was keen to keep it clean when approaching this ticket. As such, I figured we could link of to more in-depth explanations of the four intended sub-sections of Psammead (components, contexts, themes & utilities).
Based this on the notes coming out of the collaboration day the other week. In those, there's a lot of talk of examples or simple "dos & don'ts", but found those looked a little too much of an info-dump when I attempted to add some.