Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add current version to footer #167

Merged
merged 10 commits into from
Mar 19, 2024

Conversation

tmilost-bbmri-eric
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@RadovanTomik RadovanTomik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see https://stackoverflow.com/questions/38400314/including-git-commit-hash-and-date-in-webpack-build or https://duncanlock.net/blog/2023/05/23/using-git-hashes-in-vite-vuejs/ The frontend version should be dynamic. The backend version should by pulled from an api call to /api/actuator/info that returns
{"version": "3.1.1"}

@RadovanTomik
Copy link
Collaborator

RadovanTomik commented Mar 18, 2024

see https://directory.bbmri-eric.eu/#/catalogue for fon/wording inspiration in that footer and maybe change it to Application UI version and Application Server version

@tmilost-bbmri-eric tmilost-bbmri-eric merged commit aa08ee0 into main Mar 19, 2024
1 check failed
@tmilost-bbmri-eric tmilost-bbmri-eric deleted the feat/add_display_od_versions_FE_BE branch March 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants