Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove project entities #193

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

jungwire
Copy link
Contributor

Negotiator pull request:

Description:

Remove project entities

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

@jungwire jungwire linked an issue Feb 27, 2024 that may be closed by this pull request
@jungwire jungwire marked this pull request as ready for review February 28, 2024 08:10
@RadovanTomik RadovanTomik force-pushed the refactor/remove_project_entities branch from 55aca59 to 18984b5 Compare March 7, 2024 18:31
Copy link
Collaborator

@RadovanTomik RadovanTomik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also needs a DB migration script

@jungwire jungwire marked this pull request as draft March 14, 2024 08:23
@jungwire jungwire force-pushed the refactor/remove_project_entities branch from 5733de9 to 74b8cfd Compare March 20, 2024 08:34
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.03%. Comparing base (c32de8e) to head (76a89a3).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #193      +/-   ##
============================================
+ Coverage     75.88%   76.03%   +0.14%     
+ Complexity      908      887      -21     
============================================
  Files           125      119       -6     
  Lines          2700     2658      -42     
  Branches        155      155              
============================================
- Hits           2049     2021      -28     
+ Misses          541      527      -14     
  Partials        110      110              
Flag Coverage Δ
unit 76.03% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jungwire jungwire force-pushed the refactor/remove_project_entities branch from b9a9c8e to 76a89a3 Compare March 21, 2024 08:54
@jungwire jungwire marked this pull request as ready for review March 21, 2024 09:22
@jungwire jungwire merged commit eeb3324 into master Mar 21, 2024
16 checks passed
@jungwire jungwire deleted the refactor/remove_project_entities branch March 21, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] Remove project entities
2 participants