Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unintentional modification of representative resources #240

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

RadovanTomik
Copy link
Collaborator

@RadovanTomik RadovanTomik commented Mar 20, 2024

Negotiator pull request:

Description:

Fixes the accidental removal of representative rights.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.88%. Comparing base (255ce30) to head (d70f621).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #240      +/-   ##
============================================
- Coverage     75.90%   75.88%   -0.02%     
  Complexity      908      908              
============================================
  Files           125      125              
  Lines          2698     2700       +2     
  Branches        155      155              
============================================
+ Hits           2048     2049       +1     
  Misses          541      541              
- Partials        109      110       +1     
Flag Coverage Δ
unit 75.88% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik merged commit 1ab113d into master Mar 20, 2024
15 of 16 checks passed
@RadovanTomik RadovanTomik deleted the fix/resource_link branch March 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Atteched resources are removed during notification creation process
1 participant