Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authorization checks in attachment upload #267

Merged
merged 5 commits into from
Apr 8, 2024

Conversation

RadovanTomik
Copy link
Collaborator

@RadovanTomik RadovanTomik commented Apr 4, 2024

Negotiator pull request:

Description:

Fix authorization checks in attachment upload.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

@RadovanTomik RadovanTomik linked an issue Apr 4, 2024 that may be closed by this pull request
@RadovanTomik RadovanTomik requested a review from svituz April 4, 2024 10:43
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 79.16667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 76.80%. Comparing base (ce1903a) to head (7e174a1).

Files Patch % Lines
...i_eric/negotiator/service/DBAttachmentService.java 85.00% 1 Missing and 2 partials ⚠️
...iator/api/controller/v3/NegotiationController.java 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #267      +/-   ##
============================================
- Coverage     78.24%   76.80%   -1.45%     
+ Complexity      890      869      -21     
============================================
  Files           122      122              
  Lines          2708     2716       +8     
  Branches        154      157       +3     
============================================
- Hits           2119     2086      -33     
- Misses          490      524      +34     
- Partials         99      106       +7     
Flag Coverage Δ
unit 76.80% <79.16%> (-1.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik merged commit 32ea2a4 into master Apr 8, 2024
15 of 16 checks passed
@RadovanTomik RadovanTomik deleted the fix/attachments_auth branch April 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add authorization checks to attachment upload
2 participants