Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add dynamic maven project versioning #292

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

RadovanTomik
Copy link
Collaborator

@RadovanTomik RadovanTomik commented Apr 21, 2024

Negotiator pull request:

Description:

Changes the way maven project version is set. Now it is dynamically assigned during the CI pipeline.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.45%. Comparing base (8a2076c) to head (8e43518).
Report is 75 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #292      +/-   ##
============================================
+ Coverage     77.93%   78.45%   +0.52%     
- Complexity      909      973      +64     
============================================
  Files           125      133       +8     
  Lines          2773     2892     +119     
  Branches        161      163       +2     
============================================
+ Hits           2161     2269     +108     
- Misses          512      522      +10     
- Partials        100      101       +1     
Flag Coverage Δ
unit 78.45% <ø> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik self-assigned this Apr 22, 2024
@RadovanTomik RadovanTomik linked an issue Apr 22, 2024 that may be closed by this pull request
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik merged commit c4182b6 into master Apr 23, 2024
15 checks passed
@RadovanTomik RadovanTomik deleted the chore/release_pipeline branch April 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add uploading of JAR file to GitHub packages
1 participant