Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/reminder default scheduling time #320

Merged
merged 2 commits into from
May 21, 2024

Conversation

jungwire
Copy link
Contributor

@jungwire jungwire commented May 8, 2024

Negotiator pull request:

Description:

Changes the default schedule of the reminder emails from every night to Monday midnight

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.71%. Comparing base (c760e7a) to head (7a61f85).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #320   +/-   ##
=========================================
  Coverage     79.71%   79.71%           
  Complexity     1076     1076           
=========================================
  Files           146      146           
  Lines          3243     3243           
  Branches        173      173           
=========================================
  Hits           2585     2585           
  Misses          543      543           
  Partials        115      115           
Flag Coverage Δ
unit 79.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jungwire jungwire marked this pull request as ready for review May 8, 2024 11:20
@RadovanTomik RadovanTomik merged commit e81b68a into master May 21, 2024
17 checks passed
@RadovanTomik RadovanTomik deleted the fix/reminder_default_scheduling_time branch May 21, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants