Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notifications): set timestamp for sent emails #321

Merged
merged 3 commits into from
May 21, 2024

Conversation

RadovanTomik
Copy link
Collaborator

@RadovanTomik RadovanTomik commented May 13, 2024

Negotiator pull request:

Description:

Sets timestamp during email sending.

Checklist:

Make sure you tick all the boxes bellow if they are true or do not apply:

  • I have performed a self review of my code
  • My code follows Google Java Code style
  • I have made my code as simple as possible
  • I have added unit tests and the code coverage has not decreased
  • I have updated the documentation in all relevant places

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik self-assigned this May 13, 2024
@RadovanTomik RadovanTomik linked an issue May 13, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.41%. Comparing base (abb755c) to head (6077fae).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #321      +/-   ##
============================================
+ Coverage     79.39%   79.41%   +0.01%     
  Complexity     1091     1091              
============================================
  Files           147      147              
  Lines          3281     3284       +3     
  Branches        179      180       +1     
============================================
+ Hits           2605     2608       +3     
  Misses          552      552              
  Partials        124      124              
Flag Coverage Δ
unit 79.41% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
Signed-off-by: RadovanTomik <radovan.tomasik@bbmri-eric.eu>
@RadovanTomik RadovanTomik merged commit 2bee2a9 into master May 21, 2024
17 checks passed
@RadovanTomik RadovanTomik deleted the fix/email_timestamp branch May 21, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Notification email does not have sent_at value in DB
2 participants