-
Notifications
You must be signed in to change notification settings - Fork 12
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
✅ install git-lfs into Travis and fetch test data
- Loading branch information
Showing
1 changed file
with
8 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e797010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
e797010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the Travis log. It looks like git lfs successfully fetched the test data but then none of the tests were able to open the files...
e797010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we also now need an alternate solution to the Python 2.7 vs 3.5 thing. I guess we can commit both versions to the repo and have the test script search an alternate location for 3.5? Even better, once we have that mechanism, we can have an alternate file only for the RB tests, which is where things break.
e797010
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it took me a bit to figure it out but it's just like
git fetch
vsgit pull
.git lfs fetch
just downloads the files but doesn't update the text pointer. It's fixed now and Travis is happy for 3.5 at least. I was thinking along you line of just having an_27
version of the RB files.