Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/unit tests 1 #180

Merged
merged 8 commits into from
Jan 7, 2019
Merged

Fix/unit tests 1 #180

merged 8 commits into from
Jan 7, 2019

Conversation

tim-rogers
Copy link

Added subtle tweaks to some of the unit test files and warning logic regarding required LFS proxied data files.
Also defined renderDocs.sh and runUnitTests.sh shell scripts to simplify / standardize setup for document rendering and unitTest (discovery) invocations (intended for use from bbnqconda testing).

@coveralls
Copy link

coveralls commented Nov 30, 2018

Coverage Status

Coverage increased (+0.2%) to 67.293% when pulling 89e64ca on fix/unitTests_1 into 15dc15f on master.

…test set).

Added test_Sequences.py logic (set_awg_dir) to invoke config.load_conifg() when config.AWGDir is undefined.
(when running as a stand-alone test, this case was causing failures).
@matthewware
Copy link
Collaborator

Seems like mkdocs is putting directories into the href fields instead of paths to the html files. Not sure how to set this in the configuration but I'm going to look around.

@matthewware
Copy link
Collaborator

Nevermind! It was user error on my part.

Copy link
Collaborator

@matthewware matthewware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We might want to think about putting the shell scripts in a folder if we end up with many more of them, but this can wait.

@matthewware
Copy link
Collaborator

mkdocs does seem to be unhappy with the deprecated pages keyword in the mkdocs.yml and wants it to be replaced with nav.

@matthewware matthewware merged commit 946bac7 into master Jan 7, 2019
@matthewware matthewware deleted the fix/unitTests_1 branch March 18, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants