Fix: Wrong agent start-join parameter check.

BBVA · Jun 20, 2019 · 3971e9d · 3971e9d
1 parent c0eb668
commit 3971e9d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/cmd/agent.go b/cmd/agent.go
@@ -67,7 +67,7 @@ func runAgent(cmd *cobra.Command, args []string) error {
 	var err error
 
 	gossipStartJoin, _ := cmd.Flags().GetStringSlice("start-join")
-	err = urlParse(gossipStartJoin...)
+	err = urlParseNoSchemaRequired(gossipStartJoin...)
 	if err != nil {
 		return err
 	}

diff --git a/cmd/parameters.go b/cmd/parameters.go
@@ -30,6 +30,8 @@ const (
 	errUnexpectedScheme = "unexpected URL Scheme"
 )
 
+// urlParse function checks that given string parameters are valid URLs for
+// REST requests: schema + hostname [ + port ]
 func urlParse(endpoints ...string) error {
 	for _, endpoint := range endpoints {
 		url, err := url.Parse(endpoint)
@@ -49,6 +51,8 @@ func urlParse(endpoints ...string) error {
 	return nil
 }
 
+// urlParse function checks that given string parameters are valid IPs for
+// binding services: hostname + port. No schema is required.
 func urlParseNoSchemaRequired(endpoints ...string) error {
 	for _, endpoint := range endpoints {