feat: closeByModel as private method

BBVAEngineering · Oct 5, 2020 · 7791d42 · 7791d42
1 parent ba54c09
commit 7791d42
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/addon/components/modal.js b/addon/components/modal.js
@@ -116,7 +116,7 @@ export default class ModalComponent extends Component.extend({
 			return;
 		}
 
-		this.modal.closeByModel(this.model);
+		this.modal._closeByModel(this.model);
 	}
 
 	resolve(data, label = `Component '${this.model.fullname}': fulfillment`) {

diff --git a/addon/services/modal.js b/addon/services/modal.js
@@ -24,7 +24,7 @@ export default class ModalService extends Service.extend(Evented) {
 		return model.get('promise');
 	}
 
-	closeByModel(model) {
+	_closeByModel(model) {
 		this.trigger('close', model);
 		this.content.removeObject(model);
 	}