feat: add events when opening/closing a modal

addon/services/modal.js

@@ -2,8 +2,9 @@ import Service from '@ember/service';
 import { A } from '@ember/array';
 import { getOwner } from '@ember/application';
 import { isEmpty } from '@ember/utils';
+import Evented from '@ember/object/evented';
 
-export default class ModalService extends Service {
+export default class ModalService extends Service.extend(Evented) {
 	content = A();
 
 	open(name, options = {}) {
@@ -18,6 +19,8 @@ export default class ModalService extends Service {
 			this.content.addObject(modal);
 		}
 
+		this.trigger('open', modal);
+
 		return modal.get('promise');
 	}
 
@@ -37,6 +40,8 @@ export default class ModalService extends Service {
 				deferred.reject(null, `Modal: closing '${modal.fullname}'`);
 			}
 		});
+
+		this.trigger('close', key);
 	}
 
 	isOpened(name) {

package.json

@@ -60,7 +60,7 @@
   },
   "dependencies": {
     "@glimmer/tracking": "^1.0.1",
-    "ember-cli-babel": "^7.22.1",
+    "ember-cli-babel": "^7.19.0",
     "ember-cli-htmlbars": "^5.3.1",
     "ember-task-scheduler": "^2.1.0",
     "ember-transition-end": "^2.0.0"
@@ -109,6 +109,10 @@
     "semantic-release": "^17.1.1",
     "sinon": "^9.0.3"
   },
+  "resolutions": {
+    "ember-cli-babel": "~7.19.0",
+    "babel-plugin-ember-modules-api-polyfill": "2.13.0"
+  },
   "engines": {
     "node": "10.* || >= 12"
   },

tests/unit/services/modal-test.js

@@ -99,4 +99,27 @@ module('Unit | Service | modal', (hooks) => {
 		assert.equal(service.get('content').findBy('name', 'foo').get('promise._state'), PENDING);
 		assert.equal(service.get('content').findBy('name', 'bar').get('promise._state'), REJECTED);
 	});
+
+	test('it triggers events when a modal is open/closed', (assert) => {
+		const done = assert.async();
+
+		service.one('open', (modal) => {
+			assert.ok(1, 'modal is open');
+			assert.equal(modal.name, 'foo', 'modal exists as first argument');
+		});
+
+		run(() => {
+			service.open('foo');
+		});
+
+		service.one('close', (key) => {
+			assert.ok(1, 'modal is closed');
+			assert.equal(key, 'foo', 'key exists as first argument');
+			done();
+		});
+
+		run(() => {
+			service.close('foo');
+		});
+	});
 });