Skip to content

Commit

Permalink
feat(util): use transition-end from npm
Browse files Browse the repository at this point in the history
  • Loading branch information
josex2r committed Dec 5, 2019
1 parent 0fc3f44 commit fb6fe66
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 202 deletions.
3 changes: 2 additions & 1 deletion addon/components/modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import Component from '@ember/component';
import RSVP from 'rsvp';
import { camelize } from '@ember/string';
import { computed } from '@ember/object';
import { hasTransitions, onTransitionEnd } from 'ember-modal-service/utils/css-transitions';
import onTransitionEnd from 'ember-transition-end/utils/on-transition-end';
import { hasTransitions } from 'ember-modal-service/utils/css-transitions';
import { inject as service } from '@ember/service';
import { on } from '@ember/object/evented';
import { run } from '@ember/runloop';
Expand Down
2 changes: 0 additions & 2 deletions addon/utils/css-transitions/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
import onTransitionEnd from './on-transition-end';
import hasTransitions from './has-transitions';

export {
onTransitionEnd,
hasTransitions
};
52 changes: 0 additions & 52 deletions addon/utils/css-transitions/on-transition-end.js

This file was deleted.

1 change: 0 additions & 1 deletion app/utils/css-transitions/on-transition-end.js

This file was deleted.

8 changes: 8 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"scripts": {
"build": "ember build",
"check-coverage": "istanbul check-coverage coverage/coverage-final.json --statements 85 --functions 85 --branches 85 --lines 85",
"commit": "git-cz",
"lint": "npm run lint:js && npm run lint:hbs",
"lint:hbs": "ember-template-lint .",
"lint:js": "eslint --max-warnings 0 ./*.js addon app config tests",
Expand All @@ -60,7 +61,8 @@
"dependencies": {
"ember-cli-babel": "^7.4.3",
"ember-cli-htmlbars": "^3.0.0",
"ember-task-scheduler": "^1.0.2"
"ember-task-scheduler": "^1.0.2",
"ember-transition-end": "^1.0.0"
},
"devDependencies": {
"@commitlint/cli": "^7.6.0",
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/components/modal-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import sinon from 'sinon';
import waitFor from 'ember-task-scheduler/utils/wait-for';
import { A } from '@ember/array';
import { moduleForComponent, test } from 'ember-qunit';
import { onTransitionEnd } from 'ember-modal-service/utils/css-transitions';
import onTransitionEnd from 'ember-transition-end/utils/on-transition-end';
import { run } from '@ember/runloop';

const { spy } = sinon;
Expand Down
144 changes: 0 additions & 144 deletions tests/unit/utils/css-transitions/on-transition-end-test.js

This file was deleted.

0 comments on commit fb6fe66

Please sign in to comment.