feat: add ability to provide a prefix for modals #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adrigzr I'm not sure if what I did caused the CI failures - seems like the deps PRs are also failing for a similar reason. It looks like it fails on 3 of the ember try scenarios for possibly unrelated reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to make it possible for modals to live outside of the main components folder. This allows custom prefixes on the name, which adds additional flexibility to where you can put your modals in your folder structure.
This allows something along these lines:
The
info-modalcan now live insidecomponents/modals/info-modal. With a significant number of modals in an application, it can become unweidly to have a lot of top levelmodal-modals.The default fallback returns
modal-${name}as it did before.