Skip to content

Commit

Permalink
fix: 🐛 two cosmetic bugs in BBjGridExWidget
Browse files Browse the repository at this point in the history
closes #253
  • Loading branch information
hyyan committed May 17, 2023
1 parent b4ec769 commit e3ac478
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 18 deletions.
13 changes: 5 additions & 8 deletions BBjGridExWidget.bbj
Expand Up @@ -666,7 +666,7 @@ class public BBjGridExWidget extends BBjWidget implements GxColumnsManagerInterf
rem */
method public BBjGridExWidget(BBjWindow wnd!, BBjNumber id!, BBjNumber x!, BBjNumber y!, BBjNumber w!, BBjNumber h!)
#this!(null(), wnd!, id!, x!, y!, w!, h!, "")
methodend
methodend
rem /**
rem * The constructor that creates the widget on wnd!
rem *
Expand All @@ -682,7 +682,7 @@ class public BBjGridExWidget extends BBjWidget implements GxColumnsManagerInterf
rem */
method public BBjGridExWidget(BBjWindow wnd!, BBjNumber id!, BBjNumber x!, BBjNumber y!, BBjNumber w!, BBjNumber h! , BBjString template$)
#this!(null(), wnd!, id!, x!, y!, w!, h!, template$)
methodend
methodend
rem /**
rem * The constructor that creates the widget on wnd!
rem *
Expand All @@ -698,7 +698,7 @@ class public BBjGridExWidget extends BBjWidget implements GxColumnsManagerInterf
rem */
method public BBjGridExWidget(BBjString rootId!, BBjWindow wnd!, BBjNumber id!, BBjNumber x!, BBjNumber y!, BBjNumber w!, BBjNumber h!)
#this!(rootId!, wnd!, id!, x!, y!, w!, h!, "")
methodend
methodend
rem /**
rem * The constructor that creates the widget on wnd!
rem *
Expand Down Expand Up @@ -748,7 +748,7 @@ class public BBjGridExWidget extends BBjWidget implements GxColumnsManagerInterf
rem */
method public BBjGridExWidget(BBjString rootId!, BBjChildWindow wnd!)
#this!(RootId!, wnd!, "")
methodend
methodend
rem /**
rem * The constructor that creates the widget in the ChildWindow
rem *
Expand Down Expand Up @@ -926,7 +926,6 @@ class public BBjGridExWidget extends BBjWidget implements GxColumnsManagerInterf
if(null() = #RootId!)
rem not used anymore. We keep it for the getInstancesCount() method
#InstanceCount! = #InstanceCount! + 1

uuid! = UUID.randomUUID().toString().replace("-","").substring(0,8)
#RootId! = "gx-grid-" + uuid!
FI
Expand All @@ -943,9 +942,7 @@ class public BBjGridExWidget extends BBjWidget implements GxColumnsManagerInterf
rem * @see <a href="https://github.com/BBj-Plugins/BBjGridExWidget/issues/251">Issue 251</a>
rem */
method public static BBjNumber getInstanceCount()
msg$ = "Since version 1.11.1, BBjGridExWidget.getInstanceCount is deprecated and will be removed in the next release." +
"The method will return a wrong value if the BBj session is different from the one" +
"in which the grid was initiated."
msg$ = "Since version 1.11.1, BBjGridExWidget.getInstanceCount is deprecated and will be removed in the next release. The method will return a wrong value if the BBj session is different from the one in which the grid was initiated."
GxLogger.warn(msg$)
methodret #InstanceCount!
methodend
Expand Down
10 changes: 0 additions & 10 deletions GxOptions.bbj
Expand Up @@ -1234,16 +1234,6 @@ class public GxOptions
#setImmutableColumns(enabled!)
methodend
rem /**
rem * Get DeltaColumn Mode value
rem *
rem * @return BBjNumber true when enabled , false otherwise
rem *
rem * @deprecated use `GxOptions.getImmutableColumns` instead
rem */
method public BBjNumber getDeltaColumnMode()
methodret #getImmutableColumns()
methodend
rem /**
rem * @deprecated since v1.7.0 - use `GxOptions.setSuppressRowDeselection(BBjNumber value!)` instead
rem */
method public void setRowDeselection(BBjNumber value!)
Expand Down

0 comments on commit e3ac478

Please sign in to comment.