Skip to content

Commit

Permalink
refactor: deprecate PinnedRowCellRendere
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Setting the `PinnedRowCellRendere` won't affect the rendering anymore. Please
use the `CellRenderer` instead
  • Loading branch information
hyyan committed Apr 12, 2022
1 parent d3f65ca commit e43a43a
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 12 deletions.
14 changes: 8 additions & 6 deletions GxColumns.bbj
Expand Up @@ -360,6 +360,8 @@ class public GxDefaultColumnDefinition extends GxColumnDefinition
rem *
rem * <br><b><small>#Configuration</small></b>
rem * <br><b><small>#ColumnsRenderer</small></b>
rem *
rem * @deprecated since v1.7.0, Setting this value won't affect the rendering. Please use the `CellRenderer` instead.
rem */
field public GxRendererInterface PinnedRowCellRenderer! = null()
rem /**
Expand Down Expand Up @@ -1247,13 +1249,13 @@ class public GxDefaultColumnDefinition extends GxColumnDefinition
column!. add("cellRendererParams",iff(rendererParams!.entrySet().size() <> 0 , rendererParams! , null() ),err=*next)
FI

pinnedRenderer! = #getPinnedRowCellRenderer()
rem pinnedRenderer! = #getPinnedRowCellRenderer()

if(pinnedRenderer! <> null()) then
pinnedRendererParams! = pinnedRenderer!.getAsJsonObject()
column!.addProperty("pinnedRowCellRenderer", pinnedRenderer!.getCellRendererName(),err=*next)
column!. add("pinnedRowCellRendererParams",iff(pinnedRendererParams!.entrySet().size() <> 0 , pinnedRendererParams! , null() ),err=*next)
FI
rem if(pinnedRenderer! <> null()) then
rem pinnedRendererParams! = pinnedRenderer!.getAsJsonObject()
rem column!.addProperty("pinnedRowCellRenderer", pinnedRenderer!.getCellRendererName(),err=*next)
rem column!. add("pinnedRowCellRendererParams",iff(pinnedRendererParams!.entrySet().size() <> 0 , pinnedRendererParams! , null() ),err=*next)
rem FI

editor! = #getCellEditor()

Expand Down
15 changes: 9 additions & 6 deletions demo/RowPinning.bbj
Expand Up @@ -64,13 +64,16 @@ main:

renderer! = new GxRendererCustomHTML("<% "+
: "var position = params.node.rowPinned;"+
: "var content = position.toUpperCase() + ' ' + params.column.colId + ' ' + (params.rowIndex + 1);"+
: "var isCDNumber = params.column.colId == 'CDNUMBER';"+
: "var style = 'font-weight: bold;font-style: italic';"+
: "style += isCDNumber ? ';color: blue;' : ''; "+
: "print('<div class=""ag-cell-wrapper"" style=""' + style + '"">' + content + '</div>')"+
: "if(!position) print(params.value);"+
: "else {"+
: " var content = position.toUpperCase() + ' ' + params.column.colId + ' ' + (params.rowIndex + 1);"+
: " var isCDNumber = params.column.colId == 'CDNUMBER';"+
: " var style = 'font-weight: bold;font-style: italic';"+
: " style += isCDNumber ? ';color: blue;' : ''; "+
: " print('<div class=""ag-cell-wrapper"" style=""' + style + '"">' + content + '</div>')"+
: "}" +
: "%>")
grid!.getOptions().getDefaultColumnDefinition().setPinnedRowCellRenderer(renderer!)
grid!.getOptions().getDefaultColumnDefinition().setCellRenderer(renderer!)

grid!.setData(rs!)
return
Expand Down

0 comments on commit e43a43a

Please sign in to comment.